Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide from_pem_wo_parameter() to rebuild sepc256k1 identity from .pem without parameters #592

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: provide from_pem_wo_parameter() to rebuild sepc256k1 identity from .pem without parameters #592

wants to merge 2 commits into from

Conversation

readygo67
Copy link

Description

"dfx identity export xxx" normally export .pem file without parameter, looks like

"-----BEGIN EC PRIVATE KEY-----
MHQCAQEEIAgy7nZEcVHkQ4Z1Kdqby8SwyAiyKDQmtbEHTIM+WNeBoAcGBSuBBAAK
oUQDQgAEgO87rJ1ozzdMvJyZQ+GABDqUxGLvgnAnTlcInV3NuhuPv4O3VGzMGzeB
N3d26cRxD99TPtm8uo2OuzKhSiq6EQ==
-----END EC PRIVATE KEY-----
"

but currently agent-rs does not have a method to rebuild identity from it, this PR provides from_pem_wo_parameter() to achieve this purpose.

How Has This Been Tested?

test_secp256k1_public_key_wo_params() is defined for test.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@readygo67 readygo67 requested a review from a team as a code owner September 8, 2024 11:04
@sa-github-api
Copy link

Dear @readygo67,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@readygo67 @sa-github-api